Remove Valid After for Company parameters

Goal

Store only 1 Company parameter of a given uniqueName in the repository.

Why

Valid After in Company parameters was introduced initially to support different pricing strategies for different time periods and to keep track of them for auditing purposes. But company parameter tables maintenance requires an admin user rights which is security gap that can lead to serious data losses if users delete e.g. a different table by mistake - database restoration is then needed. The different parameter table of the same name and different Valid After can lead to different structures or security setup.

The long term vision is to allow end users to create multiple validAfter instances but with a reference to the same metadata set. Since metadata should not be defined differently for different validAfter dates of the same uniqueName. But no concrete plans yet. 

Measures

• Studio is and Unity will not display the Valid After field in “Create Logic” and “Create Company Parameter” dialogs and will set Valid After = 2020-01-01 by default.

• PfxAdvisor in Studio reports an alertfor any logics hacing the same uniqueName, but multiple Valid After and can automatically remove the Valid After suffix from folder names located in CalculationLogic, WorkflowFormula or PricingParameter folders.

• Package tool can fetch without adding a Valid After suffix (e.g. “+2020-01-01) using -ignoreValidAfter switch when fetching logics.

• If possible, configure Valid After as key column instead of the table level. For the rest, the new concept will be revisited after the E2E pricing is rolled out.