Remove Valid After for Calculation logics, Workflow logics

Goal

Use only 1 logic of a given uniqueName and store only 1 logic in the project repository.

Why

Logics

Valid After field was initially introduced in logics to support different pricing strategies for different time periods and keep track of them for auditing purposes. However this is not used for many years and having Valid After is causing confusing errors or issues and unexpected behavior, e.g. in combination with libraries.

The requirement for auditing the logic versions is covered by version controlling system (git). Thefore the long term vision is to remove fields validAfter and simulationSet for Calculation and Worklow logics completely from Pricefx core. But no date planned yet. 

Measures

• Studio is and Unity will not display the Valid After field in “Create Logic” dialog and will set Valid After = 2020-01-01 by default.

• PfxAdvisor in Studio reports an alert for any logics hacing the same uniqueName, but multiple Valid After and allows to automatically remove the Valid After suffix from folder names located in PricingParameter folders.

• Package tool can fetch without adding a Valid After suffix (e.g. “+2020-01-01) using -ignoreValidAfter switch when fetching logics.

• In Studio, it will be possible to automatically remove the Valid After suffix from folder names located in CalculationLogic, WorkflowFormula folders.

• One day, we will remove old logics and remove the validAfter field from the database and from the primary key. Alternatively keep it and have it always set to a constant 2020-01-01 by the backend.