Remove Valid After for Calculation and Workflow logics

Goal

Use only 1 logic of a given name.

Why

Valid After was introduced initially to support different pricing strategies for different time periods and keep track of them for auditing purposes. However this is not used for many years and having Valid After is getting counterproductive and only causing confusing errors and special treatment on the backend. Specially for libraries it is causing unexpected behavior.

  • Auditing requirement is now covered by git

  • Logics created in Studio are created with Valid After 2020-01-01 for many years already

Next steps

  • Studio and Unity will not show the Valid After field in create new logic dialog and create new logics with Valid After = 2020-01-01. Studio will not show this field also in General tab of the logic editor and Unity will not show this column in Logics screen.

  • Studio will report and alert any folders with logics of the same name, but different Valid After.

  • Package tool will stop adding a Valid After suffix (e.g. “+2020-01-01) when fetching logics.

  • Studio will automatically remove the Valid After suffix from folder names located in CalculationLogic and WorkflowFormula folders.

  • One day, we will remove old logics and remove the validAfter field from the system so it is not part of the primary key. Alternatively keep it and have it always set to 2020-01-01 by the backend.